Do not set the nsec type bit in create_nsec_bitmap

diff --git a/dnssec.c b/dnssec.c
index 856275d2fbce8266064217775a48f2cea49213f7..97dde64777d523259efd7e203a19707a35480397 100644 (file)
--- a/dnssec.c
+++ b/dnssec.c
@@ -690,7 +690,7 @@ ldns_dnssec_create_nsec_bitmap(ldns_rr_type rr_type_list[],
        uint8_t  subtype;               /* least significant octet of type */
        uint16_t windows[256]           /* Max subtype per window */
 #ifndef S_SPLINT_S
-                             = { 0 }
+                             = { 0 }   /* Initialize ALL elements with 0 */
 #endif
                                     ;
        ldns_rr_type* d;        /* used to traverse rr_type_list*/
@@ -706,10 +706,6 @@ ldns_dnssec_create_nsec_bitmap(ldns_rr_type rr_type_list[],
                return NULL;
        }
 
-       /* The NSEC type itself is in the bitmap always
-        */
-       windows[nsec_type >> 8] = nsec_type & 0xff;
-
        /* Which other windows need to be in the bitmap rdf?
         */
        for (d = rr_type_list; d < rr_type_list + size; d++) {
@@ -752,8 +748,6 @@ ldns_dnssec_create_nsec_bitmap(ldns_rr_type rr_type_list[],
 
        /* Set the bits?
         */
-       subtype = nsec_type & 0xff;
-       data[windows[nsec_type >> 8] + subtype/8] |= (0x80 >> (subtype % 8));
        for (d = rr_type_list; d < rr_type_list + size; d++) {
                subtype = *d & 0xff;
                data[windows[*d >> 8] + subtype/8] |= (0x80 >> (subtype % 8));