]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: ti: gmii-sel: fix regmap leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 27 Nov 2025 13:48:34 +0000 (14:48 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 17:24:58 +0000 (22:54 +0530)
The mmio regmap that may be allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: 5ab90f40121a ("phy: ti: gmii-sel: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org # 6.14
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20251127134834.2030-1-johan@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-gmii-sel.c

index 6cfe2538d15b12d27ed3a617ccfe03e0c211b779..6213c2b6005a5a5efae41500b1913616bfa36178 100644 (file)
@@ -512,7 +512,7 @@ static int phy_gmii_sel_probe(struct platform_device *pdev)
                        return dev_err_probe(dev, PTR_ERR(base),
                                             "failed to get base memory resource\n");
 
-               priv->regmap = regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg);
+               priv->regmap = devm_regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg);
                if (IS_ERR(priv->regmap))
                        return dev_err_probe(dev, PTR_ERR(priv->regmap),
                                             "Failed to get syscon\n");