]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb: Indicate in rootdse.c why samdb_ntds_settings_dn() is not used
authorAndrew Bartlett <abartlet@samba.org>
Wed, 31 May 2023 02:29:57 +0000 (14:29 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 14 Jun 2023 22:57:34 +0000 (22:57 +0000)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source4/dsdb/samdb/ldb_modules/rootdse.c

index 865a43256d86a49ea7181ad592276f97e63e1f6e..e4f8f83fca71d294c6599f8bdfac223f5315d25d 100644 (file)
@@ -1078,8 +1078,14 @@ static int rootdse_init(struct ldb_module *module)
                }
        }
 
-       /* For now, our own server's location in the DB is recorded in
-        * the @ROOTDSE record */
+
+       /*
+        * For now, our own server's location in the DB is recorded in
+        * the @ROOTDSE record
+        *
+        * We can't call samdb_ntds_settings_dn() in the rootdse, as
+        * that routine used the rootdse result!
+        */
        ret = dsdb_module_search(module, mem_ctx, &res,
                                 ldb_dn_new(mem_ctx, ldb, "@ROOTDSE"),
                                 LDB_SCOPE_BASE, ds_attrs,