]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/renesas-rzg2l: Reorder function calls in rzg2l_irqc_irq_disable()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thu, 6 Jun 2024 19:48:13 +0000 (20:48 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 23 Jun 2024 15:23:08 +0000 (17:23 +0200)
The order of function calls in the disable operation should be the reverse
of that in the enable operation. Thus, reorder the function calls to first
disable the parent IRQ chip before disabling the TINT IRQ.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> # on RZ/G3S
Link: https://lore.kernel.org/r/20240606194813.676823-1-prabhakar.mahadev-lad.rj@bp.renesas.com
drivers/irqchip/irq-renesas-rzg2l.c

index 861a0e5a3e97ba922f4866d6dcd9885cd053f76e..693ff285ca2c676da51b9d4a6de7decc34701fb7 100644 (file)
@@ -271,8 +271,8 @@ static void rzg2l_tint_irq_endisable(struct irq_data *d, bool enable)
 
 static void rzg2l_irqc_irq_disable(struct irq_data *d)
 {
-       rzg2l_tint_irq_endisable(d, false);
        irq_chip_disable_parent(d);
+       rzg2l_tint_irq_endisable(d, false);
 }
 
 static void rzg2l_irqc_irq_enable(struct irq_data *d)