trace: Use strncmp() to match function names

The functions specified by the user might be longer than the function in
the backtrace, potentially overflowing the memcmp(). In practice, it
should not be a relevant out-of-memory read. However, we can use
strncmp() instead.

Note that, as before, this is only a prefix match. If a function name is
longer in the backtrace it will still match.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>

diff --git a/src/utils/os_unix.c b/src/utils/os_unix.c
index d5870669a76abf28e14abf9fe5a63b3b78a95895..b665c79a2528cc18bb7764f3d49c7116b04f3b15 100644 (file)
--- a/src/utils/os_unix.c
+++ b/src/utils/os_unix.c
@@ -611,7 +611,7 @@ int testing_test_fail(const char *tag, bool is_alloc)
                        len = next - pos;
                else
                        len = os_strlen(pos);
-               if (os_memcmp(pos, func[i], len) != 0) {
+               if (os_strncmp(pos, func[i], len) != 0) {
                        if (maybe && next) {
                                pos = next + 1;
                                continue;