]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix potential double free in sslapitest.c
authorNan Xiao <nan@chinadtrace.org>
Thu, 1 Apr 2021 05:55:04 +0000 (13:55 +0800)
committerPauli <pauli@openssl.org>
Tue, 6 Apr 2021 23:08:19 +0000 (09:08 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14758)

test/sslapitest.c

index 3e5d532bf4fb17305fca4a4e4e4e3f36ce30a369..31b36b23b12fab522c82e2f6dffdc964c8fb078b 100644 (file)
@@ -2743,8 +2743,10 @@ static int execute_test_ssl_bio(int pop_ssl, bio_change_t change_bio)
 
     /* Verify changing the rbio/wbio directly does not cause leaks */
     if (change_bio != NO_BIO_CHANGE) {
-        if (!TEST_ptr(membio2 = BIO_new(BIO_s_mem())))
+        if (!TEST_ptr(membio2 = BIO_new(BIO_s_mem()))) {
+            ssl = NULL;
             goto end;
+        }
         if (change_bio == CHANGE_RBIO)
             SSL_set0_rbio(ssl, membio2);
         else