don't run icmp on Linux. it requires root or setcap

diff --git a/src/tests/modules/all.mk b/src/tests/modules/all.mk
index 3e4589b0a98535ee28a02418308143c075db399f..c1c990ddcfaa46deef0f39404140c2ebea79de08 100644 (file)
--- a/src/tests/modules/all.mk
+++ b/src/tests/modules/all.mk
@@ -14,8 +14,16 @@ FILES := $(sort $(patsubst $(DIR)/%.unlang,%,$(call FIND_FILES_SUFFIX,$(DIR),*.u
 #  Remove things which are known to fail on travis.
 #  Or which are known to have long runtimes 
 #
+#  Also don't run icmp tests on Linux, they require setcap, or root.
+#  @todo - on Linux, *check* for root, or use "getcap" to see if the
+#  unit_test_module binary has the correct permissions.
+#
 ifeq "$(TRAVIS)" "1"
   FILES_SKIP := $(filter icmp/%,$(FILES))
+
+else ifeq "$(findstring apple,$(AC_HOSTINFO))" ""
+  FILES_SKIP := $(filter icmp/%,$(FILES))
+
 else ifneq "$(RUN_SLOW_TESTS)" "1"
   FILES_SKIP += $(filter imap/%,$(FILES))
 endif