]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qla2xxx: Replace use of system_unbound_wq with system_dfl_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Fri, 31 Oct 2025 09:56:40 +0000 (10:56 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 13 Nov 2025 02:15:18 +0000 (21:15 -0500)
Currently if a user enqueue a work item using schedule_delayed_work()
the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the
API.

system_unbound_wq should be the default workqueue so as not to enforce
locality constraints for random work whenever it's not required.

Adding system_dfl_wq to encourage its use when unbound work should be
used.

The old system_unbound_wq will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251031095643.74246-2-marco.crivellari@suse.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c

index 5ffd9458665274991987c402d01f9c464fa2c946..d48d8671c18ae422c7de86283237c763aa5bac1b 100644 (file)
@@ -5280,7 +5280,7 @@ void qla24xx_sched_upd_fcport(fc_port_t *fcport)
        qla2x00_set_fcport_disc_state(fcport, DSC_UPD_FCPORT);
        spin_unlock_irqrestore(&fcport->vha->work_lock, flags);
 
-       queue_work(system_unbound_wq, &fcport->reg_work);
+       queue_work(system_dfl_wq, &fcport->reg_work);
 }
 
 static