]> git.ipfire.org Git - thirdparty/public-inbox.git/commitdiff
dskqxs: get rid of needless confess check
authorEric Wong <e@80x24.org>
Tue, 5 Sep 2023 07:37:25 +0000 (07:37 +0000)
committerEric Wong <e@80x24.org>
Wed, 6 Sep 2023 01:00:04 +0000 (01:00 +0000)
Destruction order is unpredictable at process teardown,
so confessing or warning here is unnecessary, just break
out of the sub since it's for to delete an entry, anyways.

lib/PublicInbox/DSKQXS.pm

index 7bd7773e7225ae639c55e7d2f0811bc33c6a1dba..3fcb4e40345248c53e3a396afc632b129fa2b77e 100644 (file)
@@ -106,8 +106,7 @@ sub epoll_ctl {
                $kq->EV_SET($fd, EVFILT_READ, kq_flag(EPOLLIN, $ev));
                eval { $kq->EV_SET($fd, EVFILT_WRITE, kq_flag(EPOLLOUT, $ev)) };
        } elsif ($op == EPOLL_CTL_DEL) {
-               use Carp ();
-               $kq // Carp::confess("nokq $fd");
+               $kq // return; # called in cleanup
                $kq->EV_SET($fd, EVFILT_READ, EV_DISABLE);
                eval { $kq->EV_SET($fd, EVFILT_WRITE, EV_DISABLE) };
        } else { # EPOLL_CTL_ADD