]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
Use memset + assign to VgdbShared, to avoid memcheck warning that
authorPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Sun, 23 Aug 2015 16:57:55 +0000 (16:57 +0000)
committerPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Sun, 23 Aug 2015 16:57:55 +0000 (16:57 +0000)
uninit holes bytes are written to the shared file.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15586

coregrind/m_gdbserver/remote-utils.c

index df56b63272bea45bfc217da1c8df321a62e4ddba..f6f3d0bcf34431035c28ea4bace7bb1fce6cb9eb 100644 (file)
@@ -310,17 +310,20 @@ void remote_open (const HChar *name)
 {
    const HChar *user, *host;
    int len;
-   VgdbShared vgdbinit = 
+   VgdbShared vgdbinit;
+   const int pid = VG_(getpid)();
+   Addr addr_shared;
+   SysRes o;
+   int shared_mem_fd = INVALID_DESCRIPTOR;
+
+   VG_(memset) (&vgdbinit, 0, sizeof (VgdbShared));
+   vgdbinit = (VgdbShared) 
       {0, 0, (Addr) VG_(invoke_gdbserver),
        (Addr) VG_(threads), VG_N_THREADS, sizeof(ThreadState), 
        offsetof(ThreadState, status),
        offsetof(ThreadState, os_state) + offsetof(ThreadOSstate, lwpid),
        0};
-   const int pid = VG_(getpid)();
-   Addr addr_shared;
-   SysRes o;
-   int shared_mem_fd = INVALID_DESCRIPTOR;
-   
+
    user = VG_(getenv)("LOGNAME");
    if (user == NULL) user = VG_(getenv)("USER");
    if (user == NULL) user = "???";