]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: command: Remove unused qemuBuildRomStr
authorPeter Krempa <pkrempa@redhat.com>
Mon, 4 Oct 2021 16:04:12 +0000 (18:04 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 12 Oct 2021 08:26:05 +0000 (10:26 +0200)
Now that all users were converted to qemuBuildRomProps we can remove the
old code and un-mark qemuBuildRomProps as unused.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_command.c

index 11751b31e2f04122ac9718357f22df13877432f1..5e7d9e9d0836e4c9621843f00a8dc095fa3e56e3 100644 (file)
@@ -1271,7 +1271,7 @@ qemuBuildVirtioDevStr(virBuffer *buf,
 }
 
 
-static int G_GNUC_UNUSED
+static int
 qemuBuildRomProps(virJSONValue *props,
                   virDomainDeviceInfo *info)
 {
@@ -1311,38 +1311,6 @@ qemuBuildRomProps(virJSONValue *props,
 }
 
 
-static int G_GNUC_UNUSED
-qemuBuildRomStr(virBuffer *buf,
-                virDomainDeviceInfo *info)
-{
-    if (info->romenabled || info->rombar || info->romfile) {
-        /* Passing an empty romfile= tells QEMU to disable ROM entirely for
-         * this device, and makes other settings irrelevant */
-        if (info->romenabled == VIR_TRISTATE_BOOL_NO) {
-            virBufferAddLit(buf, ",romfile=");
-            return 0;
-        }
-
-        switch (info->rombar) {
-        case VIR_TRISTATE_SWITCH_OFF:
-            virBufferAddLit(buf, ",rombar=0");
-            break;
-        case VIR_TRISTATE_SWITCH_ON:
-            virBufferAddLit(buf, ",rombar=1");
-            break;
-        case VIR_TRISTATE_SWITCH_ABSENT:
-        case VIR_TRISTATE_SWITCH_LAST:
-            break;
-        }
-        if (info->romfile) {
-           virBufferAddLit(buf, ",romfile=");
-           virQEMUBuildBufferEscapeComma(buf, info->romfile);
-        }
-    }
-
-    return 0;
-}
-
 static int
 qemuBuildIoEventFdStr(virBuffer *buf,
                       virTristateSwitch use,