Fix kdb_ldap_create_principal cleanup

entry must be initialized before all code which can jump to cleanup.

diff --git a/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c b/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c
index 1050fcd73ed5d84facf7e74e26a0d446b61064df..7494928647867a9b4bb790072137841520bf5662 100644 (file)
--- a/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c
+++ b/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c
@@ -1344,6 +1344,8 @@ kdb_ldap_create_principal(krb5_context context, krb5_principal princ,
     krb5_timestamp now;
     krb5_actkvno_node     actkvno;
 
+    memset(&entry, 0, sizeof(entry));
+
     if ((pblock == NULL) || (context == NULL)) {
         retval = EINVAL;
         goto cleanup;
@@ -1355,8 +1357,6 @@ kdb_ldap_create_principal(krb5_context context, krb5_principal princ,
         goto cleanup;
     }
 
-    memset(&entry, 0, sizeof(entry));
-
     tl_data = malloc(sizeof(*tl_data));
     if (tl_data == NULL) {
         retval = ENOMEM;