]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix ICE on atomic enumeration type with LTO
authorEric Botcazou <ebotcazou@adacore.com>
Wed, 10 Mar 2021 11:04:25 +0000 (12:04 +0100)
committerEric Botcazou <ebotcazou@adacore.com>
Wed, 10 Mar 2021 11:33:24 +0000 (12:33 +0100)
This is a strange regression whereby an enumeration type declared as
atomic (or volatile) incorrectly triggers the ODR machinery for its
values in LTO mode.

gcc/ada/
* gcc-interface/decl.c (gnat_to_gnu_entity): Build a TYPE_STUB_DECL
for the main variant of an enumeration type declared as volatile.
gcc/testsuite/
* gnat.dg/specs/lto25.ads: New test.

gcc/ada/gcc-interface/decl.c
gcc/testsuite/gnat.dg/specs/lto25.ads [new file with mode: 0644]

index fb0042369c9d9307ac675fa2e5f8823152757f64..300f7c04b0cda5146cd8f8efdebb9575e37e8ab4 100644 (file)
@@ -4682,6 +4682,10 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
          const int quals
            = TYPE_QUAL_VOLATILE
              | (Is_Atomic_Or_VFA (gnat_entity) ? TYPE_QUAL_ATOMIC : 0);
+         /* This is required by free_lang_data_in_type to disable the ODR.  */
+         if (TREE_CODE (gnu_type) == ENUMERAL_TYPE)
+           TYPE_STUB_DECL (gnu_type)
+             = create_type_stub_decl (TYPE_NAME (gnu_type), gnu_type);
          gnu_type = change_qualified_type (gnu_type, quals);
        }
 
diff --git a/gcc/testsuite/gnat.dg/specs/lto25.ads b/gcc/testsuite/gnat.dg/specs/lto25.ads
new file mode 100644 (file)
index 0000000..89876b6
--- /dev/null
@@ -0,0 +1,12 @@
+-- { dg-do compile }
+-- { dg-options "-flto" { target lto } }
+
+package Lto25 is
+
+  type Enum is (One, Two, Three) with Atomic;
+
+  type Rec is record
+    E : Enum := One;
+  end record;
+
+end Lto25;