]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ext4: release buffer in failed path in dx_probe()
authorGuo Chao <yan@linux.vnet.ibm.com>
Mon, 7 Jan 2013 04:38:47 +0000 (23:38 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 16:46:23 +0000 (08:46 -0800)
commit 0ecaef0644973e9006fdbc6974301047aaff9bc6 upstream.

If checksum fails, we should also release the buffer
read from previous iteration.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: "Darrick J. Wong" <darrick.wong@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/namei.c

index ca770306ccbece3141222840d43f88005f5055d7..8fa23b4f1a462ec27e6f75a25a177e3cf1f27263 100644 (file)
@@ -725,7 +725,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir,
                        ext4_warning(dir->i_sb, "Node failed checksum");
                        brelse(bh);
                        *err = ERR_BAD_DX_DIR;
-                       goto fail;
+                       goto fail2;
                }
                set_buffer_verified(bh);