]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: SOF: topology: Use krealloc_array() to replace krealloc()
authorZhang Heng <zhangheng@kylinos.cn>
Fri, 17 Jan 2025 01:43:43 +0000 (09:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:11 +0000 (10:45 +0200)
[ Upstream commit a05143a8f713d9ae6abc41141dac52c66fca8b06 ]

Use krealloc_array() to replace krealloc() with multiplication.
krealloc_array() has multiply overflow check, which will be safer.

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
Link: https://patch.msgid.link/20250117014343.451503-1-zhangheng@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/sof/topology.c

index cf1e63daad86bf83d5620aa845f606974daf6c78..7afded323150c819d024e3abd46f14321437ae88 100644 (file)
@@ -1267,8 +1267,8 @@ static int sof_widget_parse_tokens(struct snd_soc_component *scomp, struct snd_s
                        struct snd_sof_tuple *new_tuples;
 
                        num_tuples += token_list[object_token_list[i]].count * (num_sets - 1);
-                       new_tuples = krealloc(swidget->tuples,
-                                             sizeof(*new_tuples) * num_tuples, GFP_KERNEL);
+                       new_tuples = krealloc_array(swidget->tuples,
+                                                   num_tuples, sizeof(*new_tuples), GFP_KERNEL);
                        if (!new_tuples) {
                                ret = -ENOMEM;
                                goto err;