fixes #9461 - Make carousel ignore non-items in carousel-inner

diff --git a/js/carousel.js b/js/carousel.js
index 19e9af1ed969c7ce8efe8f619990615a3e673c6d..6d6fa0aeeb7da4f63e0c3c0733e21511261a4631 100644 (file)
--- a/js/carousel.js
+++ b/js/carousel.js
@@ -48,7 +48,7 @@
 
   Carousel.prototype.getActiveIndex = function () {
     this.$active = this.$element.find('.item.active')
-    this.$items  = this.$active.parent().children()
+    this.$items  = this.$active.parent().children('.item')
 
     return this.$items.index(this.$active)
   }

diff --git a/js/tests/unit/carousel.js b/js/tests/unit/carousel.js
index 6f69855c7736541fa8b5613f3d9a544832a9877e..562e30255fd310d3dfdb8448e8524dcebbe55284 100644 (file)
--- a/js/tests/unit/carousel.js
+++ b/js/tests/unit/carousel.js
@@ -107,4 +107,32 @@ $(function () {
     ok($('#myCarousel').data('bs.carousel').options.interval === false, 'data attribute has higher priority than default options')
     $('#myCarousel').remove()
   })
+
+  test('should skip over non-items', function () {
+    $.support.transition = false
+
+    var $template = $(
+        '<div id="myCarousel" class="carousel" data-interval="1814">'
+      + '<div class="carousel-inner">'
+      + '<div class="item active">'
+      + '<img alt="">'
+      + '</div>'
+      + '<script type="text/x-metamorph" id="thingy"></script>'
+      + '<div class="item">'
+      + '<img alt="">'
+      + '</div>'
+      + '<div class="item">'
+      + '</div>'
+      + '</div>'
+      + '</div>'
+    )
+
+    $template.carousel()
+
+    equal($template.find('.item')[0], $template.find('.active')[0], 'the first carousel item should be active')
+
+    $template.carousel(1)
+
+    equal($template.find('.item')[1], $template.find('.active')[0], 'the second carousel item should be active')
+  })
 })