]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: max31335: Fix ignored return value in set_alarm
authorNuno Sá <nuno.sa@analog.com>
Fri, 28 Nov 2025 16:36:38 +0000 (16:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:03:38 +0000 (14:03 +0100)
[ Upstream commit f07640f9fb8df2158199da1da1f8282948385a84 ]

Return the result from regmap_update_bits() instead of ignoring it
and always returning 0.

Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20251128-max31335-handler-error-v1-1-6b6f7f78dbda@analog.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-max31335.c

index dfb5bad3a3691d0968bac78cbc9d54a2ea7662ba..23b7bf16b4cd5d3e14ad0c849e7c0301ec8278c0 100644 (file)
@@ -391,10 +391,8 @@ static int max31335_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        if (ret)
                return ret;
 
-       ret = regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
-                                MAX31335_STATUS1_A1F, 0);
-
-       return 0;
+       return regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
+                                 MAX31335_STATUS1_A1F, 0);
 }
 
 static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled)