Make PMKID check easier for static analyzers

Checking sm->pmksa is sufficient here, but that seems to be too
difficult for static analyzers to follow, so avoid false reports by
explicitly checking pmkid as well.

Signed-off-by: Jouni Malinen <j@w1.fi>

diff --git a/src/ap/wpa_auth_ie.c b/src/ap/wpa_auth_ie.c
index e957c6e920714b084c072428e61f2290c396634e..1e4defcf177425d5ec3cf5ed75c018cdc66e469f 100644 (file)
--- a/src/ap/wpa_auth_ie.c
+++ b/src/ap/wpa_auth_ie.c
@@ -675,7 +675,7 @@ int wpa_validate_wpa_ie(struct wpa_authenticator *wpa_auth,
                        break;
                }
        }
-       if (sm->pmksa) {
+       if (sm->pmksa && pmkid) {
                wpa_auth_vlogger(wpa_auth, sm->addr, LOGGER_DEBUG,
                                 "PMKID found from PMKSA cache "
                                 "eap_type=%d vlan_id=%d",