]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: amlogic: Staticize some local structs
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 24 Jun 2025 18:47:57 +0000 (20:47 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 24 Jun 2025 19:51:57 +0000 (21:51 +0200)
Sparse complains:

sparse warnings: (new ones prefixed by >>)
>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:126:24: sparse: sparse:
   symbol 'multi_mux_s7' was not declared. Should it be static?
>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:135:28: sparse: sparse:
   symbol 's7_priv_data' was not declared. Should it be static?
>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:140:24: sparse: sparse:
   symbol 'multi_mux_s6' was not declared. Should it be static?
>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:154:28: sparse: sparse:
   symbol 's6_priv_data' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506122145.wWAtKBoy-lkp@intel.com/
Cc: Xianwei Zhao <xianwei.zhao@amlogic.com>
Fixes: 1f8e5dfddaa7 ("pinctrl: meson: support amlogic S6/S7/S7D SoC")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/20250624-amlogic-a4-fix-v1-1-03f0856d10cb@linaro.org
drivers/pinctrl/meson/pinctrl-amlogic-a4.c

index 2541c864086d6a5a81737810dc3a65eb15fb31d8..c8958222df8c736a79155456594e358d3afbfc31 100644 (file)
@@ -123,7 +123,7 @@ static const char *aml_bank_name[31] = {
 "GPIOCC", "TEST_N", "ANALOG"
 };
 
-const struct multi_mux multi_mux_s7[] = {
+static const struct multi_mux multi_mux_s7[] = {
        {
                .m_bank_id = AMLOGIC_GPIO_CC,
                .m_bit_offs = 24,
@@ -132,12 +132,12 @@ const struct multi_mux multi_mux_s7[] = {
        },
 };
 
-const struct aml_pctl_data s7_priv_data = {
+static const struct aml_pctl_data s7_priv_data = {
        .number = ARRAY_SIZE(multi_mux_s7),
        .p_mux = multi_mux_s7,
 };
 
-const struct multi_mux multi_mux_s6[] = {
+static const struct multi_mux multi_mux_s6[] = {
        {
                .m_bank_id = AMLOGIC_GPIO_CC,
                .m_bit_offs = 24,
@@ -151,7 +151,7 @@ const struct multi_mux multi_mux_s6[] = {
        },
 };
 
-const struct aml_pctl_data s6_priv_data = {
+static const struct aml_pctl_data s6_priv_data = {
        .number = ARRAY_SIZE(multi_mux_s6),
        .p_mux = multi_mux_s6,
 };