]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
Revert "nsrep: allow inclusion of good nameservers if there's space in selection"
authorVladimír Čunát <vladimir.cunat@nic.cz>
Tue, 24 Sep 2019 12:51:49 +0000 (14:51 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Tue, 24 Sep 2019 13:32:39 +0000 (15:32 +0200)
This reverts commit 196ebd4f0b3a55830b1e313fa82abfd8c290eedd.
It was buggy, and I can't simply recover the intended effect.

lib/nsrep.c

index 77ef7b802b2ee3647e5eddc6713aa7f2ac40f385..c8181318fa6429cb8b655b3f1057abc865e7b3f4 100644 (file)
@@ -257,7 +257,7 @@ static int eval_nsrep(const knot_dname_t *owner, const pack_t *addr_set, struct
                update_nsrep_set(ns, owner, addr_choice, score);
                ns->reputation = reputation;
                return 1; /* Stop evaluation */
-       } else if (ns->score > KR_NS_MAX_SCORE || addr_choice[KR_NSREP_MAXADDR - 1] == NULL) {
+       } else if (ns->score > KR_NS_MAX_SCORE) {
                /* Check if any server was already selected.
                 * If no, pick current server and continue evaluation. */
                update_nsrep_set(ns, owner, addr_choice, score);