]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
rdma: Avoid memory leak for skipper resource
authorLeon Romanovsky <leonro@mellanox.com>
Tue, 20 Feb 2018 12:47:18 +0000 (14:47 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Fri, 23 Feb 2018 16:42:28 +0000 (08:42 -0800)
The call to get_task_name() allocates memory which is not freed
in case of skipping the object.

Fixes: 8ecac46a60ff ("rdma: Add QP resource tracking information")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
rdma/res.c

index 2a63e712a34c0bab9b4221c5865f9a165d4e2f9a..62f5c5444b1aea135f1506667b6d10667430befc 100644 (file)
@@ -395,8 +395,10 @@ static int res_qp_parse_cb(const struct nlmsghdr *nlh, void *data)
                        comm = get_task_name(pid);
                }
 
-               if (rd_check_is_filtered(rd, "pid", pid))
+               if (rd_check_is_filtered(rd, "pid", pid)) {
+                       free(comm);
                        continue;
+               }
 
                if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME])
                        /* discard const from mnl_attr_get_str */