]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
cgraphunit: Avoid code generation differences based on -w/TREE_NO_WARNING [PR94277]
authorJakub Jelinek <jakub@redhat.com>
Tue, 24 Mar 2020 08:33:17 +0000 (09:33 +0100)
committerJakub Jelinek <jakub@redhat.com>
Tue, 7 Apr 2020 18:55:11 +0000 (20:55 +0200)
The following testcase FAILs with -fcompare-debug, but not because -g vs.
-g0 would make a difference, but because the second compilation is done with
-w in order not to emit warnings twice and -w seems to affect the *.gkd dump
content.
This is because TREE_NO_WARNING flag, or warn_unused_function does affect
not just whether a warning/pedwarn is printed, but also whether we set
TREE_PUBLIC on such decls.
The following patch makes sure we set it regardless of anything warning
related (TREE_NO_WARNING or warn_unused_function).

2020-03-24  Jakub Jelinek  <jakub@redhat.com>

PR debug/94277
* cgraphunit.c (check_global_declaration): For DECL_EXTERNAL and
non-TREE_PUBLIC non-DECL_ARTIFICIAL FUNCTION_DECLs, set TREE_PUBLIC
regardless of whether TREE_NO_WARNING is set on it or whether
warn_unused_function is true or not.

* gcc.dg/pr94277.c: New test.

gcc/ChangeLog
gcc/cgraphunit.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/pr94277.c [new file with mode: 0644]

index 2cd4b81ebe9ce8ef42ecc68d7131458b495a7919..356e7c14e3b2122999b71f280f6977e1787075ba 100644 (file)
@@ -1,6 +1,16 @@
 2020-04-07  Jakub Jelinek  <jakub@redhat.com>
 
        Backported from mainline
+       2020-03-24  Jakub Jelinek  <jakub@redhat.com>
+
+       PR debug/94277
+       * cgraphunit.c (check_global_declaration): For DECL_EXTERNAL and
+       non-TREE_PUBLIC non-DECL_ARTIFICIAL FUNCTION_DECLs, set TREE_PUBLIC
+       regardless of whether TREE_NO_WARNING is set on it or whether
+       warn_unused_function is true or not.
+
+2020-04-07  Jakub Jelinek  <jakub@redhat.com>
+
        2020-03-19  Jakub Jelinek  <jakub@redhat.com>
 
        PR tree-optimization/94211
index 4a27867b82cb2d21228f43f440ab37665d1da87a..0f933bdc758f225129d3f30c6a9c480ba0b4ea54 100644 (file)
@@ -967,15 +967,15 @@ check_global_declaration (symtab_node *snode)
       && DECL_INITIAL (decl) == 0
       && DECL_EXTERNAL (decl)
       && ! DECL_ARTIFICIAL (decl)
-      && ! TREE_NO_WARNING (decl)
-      && ! TREE_PUBLIC (decl)
-      && (warn_unused_function
-         || snode->referred_to_p (/*include_self=*/false)))
+      && ! TREE_PUBLIC (decl))
     {
-      if (snode->referred_to_p (/*include_self=*/false))
+      if (TREE_NO_WARNING (decl))
+       ;
+      else if (snode->referred_to_p (/*include_self=*/false))
        pedwarn (input_location, 0, "%q+F used but never defined", decl);
       else
-       warning (OPT_Wunused_function, "%q+F declared %<static%> but never defined", decl);
+       warning (OPT_Wunused_function, "%q+F declared %<static%> but never "
+                                      "defined", decl);
       /* This symbol is effectively an "extern" declaration now.  */
       TREE_PUBLIC (decl) = 1;
     }
index 650b86833876a9ea8c11721c5d51eaafa1e51b09..a43da5200a28840e0b6f9f9b3ebb7fd28b7b216a 100644 (file)
@@ -1,6 +1,11 @@
 2020-04-07  Jakub Jelinek  <jakub@redhat.com>
 
        Backported from mainline
+       2020-03-24  Jakub Jelinek  <jakub@redhat.com>
+
+       PR debug/94277
+       * gcc.dg/pr94277.c: New test.
+
        2020-03-19  Jakub Jelinek  <jakub@redhat.com>
 
        PR gcov-profile/94029
diff --git a/gcc/testsuite/gcc.dg/pr94277.c b/gcc/testsuite/gcc.dg/pr94277.c
new file mode 100644 (file)
index 0000000..dfe38e4
--- /dev/null
@@ -0,0 +1,11 @@
+/* PR debug/94277 */
+/* { dg-do compile } */
+/* { dg-options "-fcompare-debug" } */
+
+static void foo (void);        /* { dg-warning "used but never defined" } */
+
+void
+bar (void)
+{
+  foo ();
+}