]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: qcom: clk-alpha-pll: Fix the trion pll postdiv set rate API
authorSatya Priya Kakitapalli <quic_skakitap@quicinc.com>
Wed, 31 Jul 2024 06:29:10 +0000 (11:59 +0530)
committerBjorn Andersson <andersson@kernel.org>
Thu, 1 Aug 2024 02:56:09 +0000 (21:56 -0500)
Correct the pll postdiv shift used in clk_trion_pll_postdiv_set_rate
API. The shift value is not same for different types of plls and
should be taken from the pll's .post_div_shift member.

Fixes: 548a909597d5 ("clk: qcom: clk-alpha-pll: Add support for Trion PLLs")
Cc: stable@vger.kernel.org
Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240731062916.2680823-3-quic_skakitap@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/clk-alpha-pll.c

index 9ce45cd6e09f0cb73814cbb09ef1e1509b68d72f..eb5626095916177cf759f73a1233bb25c3ca48dd 100644 (file)
@@ -1552,8 +1552,8 @@ clk_trion_pll_postdiv_set_rate(struct clk_hw *hw, unsigned long rate,
        }
 
        return regmap_update_bits(regmap, PLL_USER_CTL(pll),
-                                 PLL_POST_DIV_MASK(pll) << PLL_POST_DIV_SHIFT,
-                                 val << PLL_POST_DIV_SHIFT);
+                                 PLL_POST_DIV_MASK(pll) << pll->post_div_shift,
+                                 val << pll->post_div_shift);
 }
 
 const struct clk_ops clk_alpha_pll_postdiv_trion_ops = {