]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: hostcpu: Correctly report total number of vcpus in virHostCPUGetMap
authorNitesh Konkar <niteshkonkar.libvirt@gmail.com>
Thu, 25 May 2017 10:17:43 +0000 (15:47 +0530)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 30 May 2017 08:42:28 +0000 (10:42 +0200)
Callers expect the return value to be the total number of vcpus in the
host (including offline vcpus). The refactor in c67e04e25fa58104e0fae41
broke this assumption by using virHostCPUGetOnlineBitmap which only
creates a bitmap long enough to hold the last online vcpu.

Report the full number of host vcpus by returning value from
virHostCPUGetCount().

Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
src/util/virhostcpu.c

index aa9cfeac203c2bd314ddc524891ded351a2f2346..c485a97211e18a86da8fba540c5a0670de6fda6a 100644 (file)
@@ -1093,7 +1093,7 @@ virHostCPUGetMap(unsigned char **cpumap,
     if (online)
         *online = virBitmapCountBits(cpus);
 
-    ret = virBitmapSize(cpus);
+    ret = virHostCPUGetCount();
 
  cleanup:
     if (ret < 0 && cpumap)