Check for more parse errors when reading dicts. Bug found by Coverity

diff --git a/src/lib/dict.c b/src/lib/dict.c
index 439f80ff9a9b2f88d0f20b5e7ae270b9ef58d0ee..c364e274f4662e62c3ad73f62d6e1ca96f89f5d4 100644 (file)
--- a/src/lib/dict.c
+++ b/src/lib/dict.c
@@ -1253,6 +1253,12 @@ static int process_vendor(const char* fn, const int line, char **argv,
                length = (int) (p[2] - '0');
 
                if (p[3] == ',') {
+                       if (!p[4]) {
+                               fr_strerror_printf("dict_init: %s[%d]: Invalid format for VENDOR.  Expected text like \"1,1\", got \"%s\"",
+                                  fn, line, p);
+                               return -1;
+                       }
+
                        if ((p[4] != 'c') ||
                            (p[5] != '\0')) {
                                fr_strerror_printf("dict_init: %s[%d]: Invalid format for VENDOR.  Expected text like \"1,1\", got \"%s\"",