]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Add message to terminal when running snapshot-revert
authorHaruka Ohata <ohata.haruka@fujitsu.com>
Wed, 30 Nov 2022 08:04:07 +0000 (17:04 +0900)
committerJán Tomko <jtomko@redhat.com>
Wed, 7 Dec 2022 13:33:28 +0000 (14:33 +0100)
When running virsh snapshot-* command, such as snapshot-create-as /
snapshot-delete, it prints a result message.
On the other hand virsh snapshot-revert command doesn't print a result
message.

So, This patch fixes to add message when running virsh snapshot-revert
command.

    # virsh snapshot-create-as vm1 test1
    Domain snapshot test01 created
    # virsh snapshot-revert vm1 test1

    # virsh snapshot-delete vm1 test1
    Domain snapshot test01 deleted

Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
tests/virsh-snapshot
tools/virsh-snapshot.c

index 4c64bb537b561f60889468479dc0e71c7da0511a..b09273917b79cea1a93eebd0332244b152ae5791 100755 (executable)
@@ -100,11 +100,14 @@ Domain snapshot s1 created
 
 Domain snapshot s3 created
 Domain snapshot s2 created
+Domain snapshot s3 reverted
 
 Domain snapshot s6 created
 Domain snapshot s5 created
+Domain snapshot s6 reverted
 
 Domain snapshot s4 created
+Domain snapshot s1 reverted
 
 Domain snapshot s7 created
 Domain snapshot s8 created
index 8fa64ba903c2ec671295cae4c02763628cbe11ea..68908cd10a4a149d4089836f71c939550d6fdfbe 100644 (file)
@@ -1783,6 +1783,10 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd)
         result = virDomainRevertToSnapshot(snapshot, flags);
     }
 
+    if (result < 0)
+        vshError(ctl, _("Failed to revert snapshot %s"), name);
+    else
+        vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name);
     return result >= 0;
 }