]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
src: allow validation flag in interface define
authorKristina Hanicova <khanicov@redhat.com>
Fri, 20 Aug 2021 11:28:51 +0000 (13:28 +0200)
committerJán Tomko <jtomko@redhat.com>
Fri, 20 Aug 2021 13:41:22 +0000 (15:41 +0200)
We need to validate the XML against schema if option 'validate'
was passed to the 'iface-define' virsh command. For that we need
to allow validation flag and propagate flags to parse function.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/interface/interface_backend_netcf.c
src/test/test_driver.c

index 9f93cdd65702b622aa14529666f8dfd94dd49672..78fd4f9bc773b4379624adb25f311acd09d2a075 100644 (file)
@@ -894,11 +894,11 @@ static virInterfacePtr netcfInterfaceDefineXML(virConnectPtr conn,
     virInterfaceDef *ifacedef = NULL;
     virInterfacePtr ret = NULL;
 
-    virCheckFlags(0, NULL);
+    virCheckFlags(VIR_INTERFACE_DEFINE_VALIDATE, NULL);
 
     virObjectLock(driver);
 
-    ifacedef = virInterfaceDefParseString(xml, 0);
+    ifacedef = virInterfaceDefParseString(xml, flags);
     if (!ifacedef) {
         /* error was already reported */
         goto cleanup;
index 450510ee54671d109641cac38fe25a3f2c008dd7..67db02b25d5675b7ae40b77d09f5d21bb0d9bbe6 100644 (file)
@@ -6156,10 +6156,10 @@ testInterfaceDefineXML(virConnectPtr conn,
     virInterfaceDef *objdef;
     virInterfacePtr ret = NULL;
 
-    virCheckFlags(0, NULL);
+    virCheckFlags(VIR_INTERFACE_DEFINE_VALIDATE, NULL);
 
     virObjectLock(privconn);
-    if ((def = virInterfaceDefParseString(xmlStr, 0)) == NULL)
+    if ((def = virInterfaceDefParseString(xmlStr, flags)) == NULL)
         goto cleanup;
 
     if ((obj = virInterfaceObjListAssignDef(privconn->ifaces, def)) == NULL)