]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rapidio: Replace 'select' DMAENGINES 'with depends on'
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 28 Jul 2020 22:19:40 +0000 (01:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 06:44:26 +0000 (08:44 +0200)
[ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ]

Enabling a whole subsystem from a single driver 'select' is frowned
upon and won't be accepted in new drivers, that need to use 'depends on'
instead. Existing selection of DMAENGINES will then cause circular
dependencies. Replace them with a dependency.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rapidio/Kconfig

index 3e3be57e9a1a1a6aaa9af2f11066827e8be3cbea..4d0c1a40a6e659ff0c5eb6bbcea830fc4ca3a728 100644 (file)
@@ -25,7 +25,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
 config RAPIDIO_DMA_ENGINE
        bool "DMA Engine support for RapidIO"
        depends on RAPIDIO
-       select DMADEVICES
+       depends on DMADEVICES
        select DMA_ENGINE
        help
          Say Y here if you want to use DMA Engine frameork for RapidIO data