tests: Fix false positive in testConfRoundTrip

testConfRoundTrip would return 0 (success) if virConfWriteMem succeeded
and virTestCompareToFile failed.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>

diff --git a/tests/virconftest.c b/tests/virconftest.c
index ab29b5b712b6ddd639c32e597575179c556309bd..cac3718495a9c040e2698e8546d97ed7f5f1d364 100644 (file)
--- a/tests/virconftest.c
+++ b/tests/virconftest.c
@@ -51,8 +51,7 @@ static int testConfRoundTrip(const void *opaque)
         fprintf(stderr, "Failed to process %s\n", srcfile);
         goto cleanup;
     }
-    ret = virConfWriteMem(buffer, &len, conf);
-    if (ret < 0) {
+    if (virConfWriteMem(buffer, &len, conf) < 0) {
         fprintf(stderr, "Failed to serialize %s back\n", srcfile);
         goto cleanup;
     }