]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: imu: st_lsm6dsx: fix ODR check in st_lsm6dsx_write_raw
authorLorenzo Bianconi <lorenzo@kernel.org>
Sun, 27 Oct 2019 18:02:30 +0000 (19:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Dec 2019 19:08:31 +0000 (20:08 +0100)
[ Upstream commit fc3f6ad7f5dc6c899fbda0255865737bac88c2e0 ]

Since st_lsm6dsx i2c master controller relies on accel device as trigger
and slave devices can run at different ODRs we must select an accel_odr >=
slave_odr. Report real accel ODR in st_lsm6dsx_check_odr() in order to
properly set sensor frequency in st_lsm6dsx_write_raw and avoid to
report unsupported frequency

Fixes: 6ffb55e5009ff ("iio: imu: st_lsm6dsx: introduce ST_LSM6DSX_ID_EXT sensor ids")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c

index 41341cf2d982193c590c6804413e77646d022818..ba89cbbb73ae3ea2393ba19e004a422fc063e111 100644 (file)
@@ -705,8 +705,7 @@ int st_lsm6dsx_check_odr(struct st_lsm6dsx_sensor *sensor, u16 odr, u8 *val)
                return -EINVAL;
 
        *val = odr_table->odr_avl[i].val;
-
-       return 0;
+       return odr_table->odr_avl[i].hz;
 }
 
 static u16 st_lsm6dsx_check_odr_dependency(struct st_lsm6dsx_hw *hw, u16 odr,
@@ -869,8 +868,10 @@ static int st_lsm6dsx_write_raw(struct iio_dev *iio_dev,
        case IIO_CHAN_INFO_SAMP_FREQ: {
                u8 data;
 
-               err = st_lsm6dsx_check_odr(sensor, val, &data);
-               if (!err)
+               val = st_lsm6dsx_check_odr(sensor, val, &data);
+               if (val < 0)
+                       err = val;
+               else
                        sensor->odr = val;
                break;
        }