CVE-2020-25722 s4/cracknames: add comment pointing to samldb spn handling

These need to stay a little bit in sync. The reverse comment is there.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14564

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c
index 235276bc4c87684aeb57d13b1fcb2f30b73a25a7..5af62f0b71eb2e102e4e5bac1c7d4e6c0b0377a5 100644 (file)
--- a/source4/dsdb/samdb/cracknames.c
+++ b/source4/dsdb/samdb/cracknames.c
@@ -79,6 +79,12 @@ static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(struct ldb_context *ldb_ct
                                                      const char *alias_from,
                                                      char **alias_to)
 {
+       /*
+        * Some of the logic of this function is mirrored in find_spn_alias()
+        * in source4/dsdb.samdb/ldb_modules/samldb.c. If you change this to
+        * not return the first matched alias, you will need to rethink that
+        * function too.
+        */
        unsigned int i;
        int ret;
        struct ldb_result *res;