]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
auth_token.c: add NULL initialization
authorLev Stipakov <lev@openvpn.net>
Fri, 7 Jan 2022 12:35:50 +0000 (14:35 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 10 Jan 2022 16:50:12 +0000 (17:50 +0100)
This fixes

  error C4703: potentially uninitialized local pointer variable
'b64output' used

found by arm64 msvc compiler with SDL enabled.

Not sure why this is not triggered on x86/x64.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20220107123550.188-1-lstipakov@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23511.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/auth_token.c

index e88754640f2615dfdca84fea90d46dbed5e4f4a8..ceae68f69517262fa025df4329e89c31c013fbe5 100644 (file)
@@ -259,7 +259,7 @@ generate_auth_token(const struct user_pass *up, struct tls_multi *multi)
     ASSERT(buf_write(&token, &timestamp, sizeof(timestamp)));
     ASSERT(buf_write(&token, hmac_output, sizeof(hmac_output)));
 
-    char *b64output;
+    char *b64output = NULL;
     openvpn_base64_encode(BPTR(&token), BLEN(&token), &b64output);
 
     struct buffer session_token = alloc_buf_gc(