]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix memory leak in peer cache Digest exchange
authorAmos Jeffries <squid3@treenet.co.nz>
Wed, 22 Jan 2014 03:17:25 +0000 (20:17 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Wed, 22 Jan 2014 03:17:25 +0000 (20:17 -0700)
 Detected by Coverity Scan. Issue 1094115.

src/peer_digest.cc

index 0d303a99d493c74d2a10affa71f24c5250887ff8..7cf1486477ee3e0a32a2a3b71ddbe3eb04764ffd 100644 (file)
@@ -300,7 +300,7 @@ peerDigestRequest(PeerDigest * pd)
 {
     CachePeer *p = pd->peer;
     StoreEntry *e, *old_e;
-    char *url;
+    char *url = NULL;
     const cache_key *key;
     HttpRequest *req;
     DigestFetchState *fetch = NULL;
@@ -398,6 +398,8 @@ peerDigestRequest(PeerDigest * pd)
 
     storeClientCopy(fetch->sc, e, tempBuffer,
                     peerDigestHandleReply, fetch);
+
+    safe_free(url);
 }
 
 /* Handle the data copying .. */