]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vsh: Define HAVE_STDARG_H before including readline
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 2 Sep 2020 14:37:04 +0000 (16:37 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Sep 2020 14:25:43 +0000 (16:25 +0200)
As it turned out my previous commits which switched from HAVE_ to
WITH_ and dropped stdarg.h detection were a bit too aggressive.
Because of reasons described in 9ea3424a178 we need to define
HAVE_STDARG_H before including readline otherwise macos build
fails. Honestly, I still don't fully understand the problem so I
am not going to bother you with "explanation".

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/vsh.c

index 2511089e6e2e09308581205f36d0d19e71c2c98c..ef2a3f62d74618f9f1e90510e82d58f346fdf665 100644 (file)
 #include <signal.h>
 
 #if WITH_READLINE
+/* In order to have proper rl_message declaration with older
+ * versions of readline, we have to declare this. See 9ea3424a178
+ * for more info. */
+# define HAVE_STDARG_H
 # include <readline/readline.h>
 # include <readline/history.h>
 #endif