ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered

sata_dwc_enable_interrupts() is called before platform_get_irq() and
ata_host_activate(), leaving the SATA controller's interrupt mask
enabled without a registered handler.  If a later step fails (irq
request, phy init, etc.) or if the controller asserts an interrupt
during probe, the irq line may fire with no handler, causing a
spurious interrupt storm.

Move sata_dwc_enable_interrupts() after ata_host_activate() so that
interrupts are only unmasked once the handler is registered and the
core is fully initialized.

Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 4fc22ce4bd9aa2033edbd5ee1f979f463520cbd6..e10eeb8ca0305ddb5ed7485dd95841d26a8edcf7 100644 (file)
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1169,9 +1169,6 @@ static int sata_dwc_probe(struct platform_device *ofdev)
        /* Save dev for later use in dev_xxx() routines */
        hsdev->dev = dev;
 
-       /* Enable SATA Interrupts */
-       sata_dwc_enable_interrupts(hsdev);
-
        /* Get SATA interrupt number */
        irq = irq_of_parse_and_map(np, 0);
        if (!irq) {
@@ -1204,6 +1201,8 @@ static int sata_dwc_probe(struct platform_device *ofdev)
        if (err)
                dev_err(dev, "failed to activate host");
 
+       /* Enable SATA Interrupts */
+       sata_dwc_enable_interrupts(hsdev);
        return 0;
 
 error_out: