]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kselftest/arm64: mte: fix printf type warnings about __u64
authorAndre Przywara <andre.przywara@arm.com>
Fri, 16 Aug 2024 15:32:49 +0000 (16:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:52:43 +0000 (13:52 +0100)
[ Upstream commit 7e893dc81de3e342156389ea0b83ec7d07f25281 ]

When printing the signal context's PC, we use a "%lx" format specifier,
which matches the common userland (glibc's) definition of uint64_t as an
"unsigned long". However the structure in question is defined in a
kernel uapi header, which uses a self defined __u64 type, and the arm64
kernel headers define this using "int-ll64.h", so it becomes an
"unsigned long long". This mismatch leads to the usual compiler warning.

The common fix would be to use "PRIx64", but because this is defined by
the userland's toolchain libc headers, it wouldn't match as well. Since
we know the exact type of __u64, just use "%llx" here instead, to silence
this warning.

This also fixes a more severe typo: "$lx" is not a valid format
specifier.

Fixes: 191e678bdc9b ("kselftest/arm64: Log unexpected asynchronous MTE faults")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240816153251.2833702-7-andre.przywara@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/arm64/mte/mte_common_util.c

index 00ffd34c66d301ee7d5c99e6b8d9d5d944520b7f..1120f5aa76550fe51ba18b0c976795ae93d1c48a 100644 (file)
@@ -38,7 +38,7 @@ void mte_default_handler(int signum, siginfo_t *si, void *uc)
                        if (cur_mte_cxt.trig_si_code == si->si_code)
                                cur_mte_cxt.fault_valid = true;
                        else
-                               ksft_print_msg("Got unexpected SEGV_MTEAERR at pc=$lx, fault addr=%lx\n",
+                               ksft_print_msg("Got unexpected SEGV_MTEAERR at pc=%llx, fault addr=%lx\n",
                                               ((ucontext_t *)uc)->uc_mcontext.pc,
                                               addr);
                        return;
@@ -64,7 +64,7 @@ void mte_default_handler(int signum, siginfo_t *si, void *uc)
                        exit(1);
                }
        } else if (signum == SIGBUS) {
-               ksft_print_msg("INFO: SIGBUS signal at pc=%lx, fault addr=%lx, si_code=%lx\n",
+               ksft_print_msg("INFO: SIGBUS signal at pc=%llx, fault addr=%lx, si_code=%x\n",
                                ((ucontext_t *)uc)->uc_mcontext.pc, addr, si->si_code);
                if ((cur_mte_cxt.trig_range >= 0 &&
                     addr >= MT_CLEAR_TAG(cur_mte_cxt.trig_addr) &&