ASoC: renesas: rz-ssi: Use readl_poll_timeout_atomic()

Use readl_poll_timeout_atomic() instead of hardcoding something similar.
While at it replace dev_info() with dev_warn_ratelimited() as the
rz_ssi_set_idle() can also be called from IRQ context and if the SSI
idle is not properly set this is at least a warning for user.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20241210170953.2936724-11-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c
index 1a98f6b3e6a7e88dfea07fddb50291b5791d9024..03d409d3070c9b235e4f3748b5025d79cb824e20 100644 (file)
--- a/sound/soc/renesas/rz-ssi.c
+++ b/sound/soc/renesas/rz-ssi.c
@@ -9,6 +9,7 @@
 #include <linux/clk.h>
 #include <linux/dmaengine.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/module.h>
 #include <linux/pm_runtime.h>
 #include <linux/reset.h>
@@ -307,7 +308,8 @@ static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, unsigned int rate,
 
 static void rz_ssi_set_idle(struct rz_ssi_priv *ssi)
 {
-       int timeout;
+       u32 tmp;
+       int ret;
 
        /* Disable irqs */
        rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TUIEN | SSICR_TOIEN |
@@ -320,15 +322,9 @@ static void rz_ssi_set_idle(struct rz_ssi_priv *ssi)
                              SSISR_RUIRQ), 0);
 
        /* Wait for idle */
-       timeout = 100;
-       while (--timeout) {
-               if (rz_ssi_reg_readl(ssi, SSISR) & SSISR_IIRQ)
-                       break;
-               udelay(1);
-       }
-
-       if (!timeout)
-               dev_info(ssi->dev, "timeout waiting for SSI idle\n");
+       ret = readl_poll_timeout_atomic(ssi->base + SSISR, tmp, (tmp & SSISR_IIRQ), 1, 100);
+       if (ret)
+               dev_warn_ratelimited(ssi->dev, "timeout waiting for SSI idle\n");
 
        /* Hold FIFOs in reset */
        rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_FIFO_RST);