]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: libertas: fix memory leak in lbs_init_adapter()
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 8 Dec 2022 12:14:48 +0000 (20:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:26:35 +0000 (16:26 +0100)
[ Upstream commit 16a03958618fb91bb1bc7077cf3211055162cc2f ]

When kfifo_alloc() failed in lbs_init_adapter(), cmd buffer is not
released. Add free memory to processing error path.

Fixes: 7919b89c8276 ("libertas: convert libertas driver to use an event/cmdresp queue")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221208121448.2845986-1-shaozhengchao@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/libertas/main.c

index aefa88f4f29ce6076c57eda56ee6a4fefbe5c1a6..feb204cd74a9a819a12b950cbfa5e1e7114c7322 100644 (file)
@@ -872,6 +872,7 @@ static int lbs_init_adapter(struct lbs_private *priv)
        ret = kfifo_alloc(&priv->event_fifo, sizeof(u32) * 16, GFP_KERNEL);
        if (ret) {
                pr_err("Out of memory allocating event FIFO buffer\n");
+               lbs_free_cmd_buffer(priv);
                goto out;
        }