Bug 449248: Improve $product->group_controls - Patch by Frédéric Buclin <LpSolit...

diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index edc621f6705b6c20e076258ebdabc13fc7c792f6..95a0e38407a3cd4a04935c7176e67165669b8cf8 100644 (file)
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -120,10 +120,11 @@ sub group_controls {
                   ORDER BY groups.name};
         $self->{group_controls} = 
             $dbh->selectall_hashref($query, 'id', undef, $self->id);
-        foreach my $group (keys(%{$self->{group_controls}})) {
-            $self->{group_controls}->{$group}->{'group'} = 
-                new Bugzilla::Group($group);
-        }
+
+        # For each group ID listed above, create and store its group object.
+        my @gids = keys %{$self->{group_controls}};
+        my $groups = Bugzilla::Group->new_from_list(\@gids);
+        $self->{group_controls}->{$_->id}->{group} = $_ foreach @$groups;
     }
     return $self->{group_controls};
 }