]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetStorageSourceByDevstr: Use virDomainDiskByTarget
authorPeter Krempa <pkrempa@redhat.com>
Mon, 7 Dec 2020 12:04:29 +0000 (13:04 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 8 Dec 2020 14:12:33 +0000 (15:12 +0100)
The function replaces the open-coded block.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index e4322aa2f6eed7061297e8a2f36a125b71ce5615..fc24b551e59f82e4635594fa73a0433d256c354f 100644 (file)
@@ -9953,7 +9953,6 @@ qemuDomainGetStorageSourceByDevstr(const char *devstr,
     virStorageSourcePtr src = NULL;
     g_autofree char *target = NULL;
     unsigned int idx;
-    size_t i;
 
     if (virStorageFileParseBackingStoreStr(devstr, &target, &idx) < 0) {
         virReportError(VIR_ERR_INVALID_ARG,
@@ -9961,14 +9960,7 @@ qemuDomainGetStorageSourceByDevstr(const char *devstr,
         return NULL;
     }
 
-    for (i = 0; i < def->ndisks; i++) {
-        if (STREQ(target, def->disks[i]->dst)) {
-            disk = def->disks[i];
-            break;
-        }
-    }
-
-    if (!disk) {
+    if (!(disk = virDomainDiskByTarget(def, target))) {
         virReportError(VIR_ERR_INVALID_ARG,
                        _("failed to find disk '%s'"), target);
         return NULL;