]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
cmp_hdr.c: Fix minor Coverity issue CID 1473605
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Mon, 8 Mar 2021 07:04:54 +0000 (08:04 +0100)
committerDr. David von Oheimb <dev@ddvo.net>
Tue, 9 Mar 2021 10:02:41 +0000 (11:02 +0100)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14460)

crypto/cmp/cmp_hdr.c

index 58b07dd8b2ebc6e0b45c9c142af1018d6ce27fa9..a1770c1204b3cc7ffa9ca08bf502279ac29913c6 100644 (file)
@@ -283,9 +283,6 @@ int ossl_cmp_hdr_set_transactionID(OSSL_CMP_CTX *ctx, OSSL_CMP_PKIHEADER *hdr)
         OPENSSL_free(tid);
     }
 
-    if (ctx->transactionID == NULL
-        && !set_random(&ctx->transactionID, ctx, OSSL_CMP_TRANSACTIONID_LENGTH))
-        return 0;
     return ossl_cmp_asn1_octet_string_set1(&hdr->transactionID,
                                            ctx->transactionID);
 }