]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: Only dump PAT when xe_hw_engines_init_early fails
authorMaarten Lankhorst <dev@lankhorst.se>
Thu, 19 Jun 2025 10:49:04 +0000 (12:49 +0200)
committerMaarten Lankhorst <dev@lankhorst.se>
Thu, 26 Jun 2025 20:11:35 +0000 (22:11 +0200)
After discussion with Lucas De Marchi, it turns out that is the
specific caller requiring a dump. This allows us to cleanup
gt_init in a bit.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250619104858.418440-18-dev@lankhorst.se
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
drivers/gpu/drm/xe/xe_gt.c

index 6bc793043b400f0371aa5cc698bee95cc0677f60..98360986df7dbfff3fbdb3e915ba6b0cb69e2cf7 100644 (file)
@@ -464,8 +464,10 @@ static int gt_fw_domain_init(struct xe_gt *gt)
        xe_gt_mcr_init(gt);
 
        err = xe_hw_engines_init_early(gt);
-       if (err)
+       if (err) {
+               dump_pat_on_error(gt);
                goto err_force_wake;
+       }
 
        err = xe_hw_engine_class_sysfs_init(gt);
        if (err)
@@ -486,7 +488,6 @@ static int gt_fw_domain_init(struct xe_gt *gt)
        return 0;
 
 err_force_wake:
-       dump_pat_on_error(gt);
        xe_force_wake_put(gt_to_fw(gt), fw_ref);
 
        return err;