]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
virtiofsd: Extend size of fuse_conn_info->capable and ->want fields
authorVivek Goyal <vgoyal@redhat.com>
Tue, 8 Feb 2022 20:48:07 +0000 (15:48 -0500)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Thu, 17 Feb 2022 17:22:26 +0000 (17:22 +0000)
->capable keeps track of what capabilities kernel supports and ->wants keep
track of what capabilities filesytem wants.

Right now these fields are 32bit in size. But now fuse has run out of
bits and capabilities can now have bit number which are higher than 31.

That means 32 bit fields are not suffcient anymore. Increase size to 64
bit so that we can add newer capabilities and still be able to use existing
code to check and set the capabilities.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20220208204813.682906-5-vgoyal@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
tools/virtiofsd/fuse_common.h
tools/virtiofsd/fuse_lowlevel.c

index 0c2665b9772639c4cce523f457800d11e6de0b54..6f8a9882022901755d0cc31eef86b10d73a900b1 100644 (file)
@@ -439,7 +439,7 @@ struct fuse_conn_info {
     /**
      * Capability flags that the kernel supports (read-only)
      */
-    unsigned capable;
+    uint64_t capable;
 
     /**
      * Capability flags that the filesystem wants to enable.
@@ -447,7 +447,7 @@ struct fuse_conn_info {
      * libfuse attempts to initialize this field with
      * reasonable default values before calling the init() handler.
      */
-    unsigned want;
+    uint64_t want;
 
     /**
      * Maximum number of pending "background" requests. A
index 03d60f462a7da9c18010ab35307a6389c4e06cb0..794185fb33ccc36689fba46b0d0832b9c345c8c0 100644 (file)
@@ -2070,7 +2070,7 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid,
     if (se->conn.want & (~se->conn.capable)) {
         fuse_log(FUSE_LOG_ERR,
                  "fuse: error: filesystem requested capabilities "
-                 "0x%x that are not supported by kernel, aborting.\n",
+                 "0x%llx that are not supported by kernel, aborting.\n",
                  se->conn.want & (~se->conn.capable));
         fuse_reply_err(req, EPROTO);
         se->error = -EPROTO;