]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
HID: i2c-hid: improve i2c_hid_get_report error message
authorWentao Guan <guanwentao@uniontech.com>
Fri, 14 Feb 2025 11:04:18 +0000 (19:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:37:37 +0000 (14:37 +0200)
[ Upstream commit 723aa55c08c9d1e0734e39a815fd41272eac8269 ]

We have two places to print "failed to set a report to ...",
use "get a report from" instead of "set a report to", it makes
people who knows less about the module to know where the error
happened.

Before:
i2c_hid_acpi i2c-FTSC1000:00: failed to set a report to device: -11

After:
i2c_hid_acpi i2c-FTSC1000:00: failed to get a report from device: -11

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/i2c-hid/i2c-hid-core.c

index 045db6f0fb4c4f81633515dd2f855245be6cf98a..3dcdd3368b463e13bdd5e8fc067088da8fa3d9f4 100644 (file)
@@ -258,7 +258,7 @@ static int i2c_hid_get_report(struct i2c_hid *ihid,
                             ihid->rawbuf, recv_len + sizeof(__le16));
        if (error) {
                dev_err(&ihid->client->dev,
-                       "failed to set a report to device: %d\n", error);
+                       "failed to get a report from device: %d\n", error);
                return error;
        }