ar: Assume epoch if ar_date is bogus.

If the ar header contains a bogus ar_date then in verbose mode we would
get a NULL pointer from localtime. Just assume the entry was created
during the epoch.

https://sourceware.org/bugzilla/show_bug.cgi?id=23754

Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/src/ChangeLog b/src/ChangeLog
index d057669c0c37f8ff58b23d88fa80d484b0cb5d34..40de5a09503494da0cc8b8badd241f89c1b6218a 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2018-10-14  Mark Wielaard  <mark@klomp.org>
+
+       * ar.c (do_oper_extract): Assume epoch if ar_date is bogus.
+
 2018-10-14  Mark Wielaard  <mark@klomp.org>
 
        * findtextrel.c (process_file): Check that sh_entsize is not zero.

diff --git a/src/ar.c b/src/ar.c
index 6f98f75d9f12d840a58b593766983cd4b8631d6d..d70f1f467090d615320eeb8769b8710549a4b356 100644 (file)
--- a/src/ar.c
+++ b/src/ar.c
@@ -539,8 +539,14 @@ do_oper_extract (int oper, const char *arfname, char **argv, int argc,
              else if (oper == oper_list)
                {
                  char datestr[100];
-                 strftime (datestr, sizeof (datestr), "%b %e %H:%M %Y",
-                           localtime (&arhdr->ar_date));
+                 struct tm *tp = localtime (&arhdr->ar_date);
+                 if (tp == NULL)
+                   {
+                     time_t time = 0;
+                     tp = localtime (&time);
+                   }
+
+                 strftime (datestr, sizeof (datestr), "%b %e %H:%M %Y", tp);
 
                  printf ("%c%c%c%c%c%c%c%c%c %u/%u %6ju %s %s\n",
                          (arhdr->ar_mode & S_IRUSR) ? 'r' : '-',