res_pjsip_authenticator_digest: Don't use source port in nonce verification

From the issue reporter:
"res_pjsip_outbound_authenticator_digest builds a nonce that is a hash of
the timestamp, the source address, the source port, a server UUID that is
calculated at startup, and the authentication realm.

Rather than caching nonces that we create, we instead attempt to re-calculate
the nonce when receiving an incoming request with authentication. We then
compare the re-calculated nonce to the incoming nonce, and if they don't match,
then authentication has failed early.

The problem is that it is possible, especially when using TCP, to receive two
requests from the same endpoint but have differing source ports for those
requests. Asterisk itself commonly will use different source ports for
outbound TCP requests."

This patch removes the source port dependency when building the nonce.

ASTERISK-25978 #close

Change-Id: I871b5f4adce102df1c4988066283095ec509dffe

diff --git a/res/res_pjsip_authenticator_digest.c b/res/res_pjsip_authenticator_digest.c
index d56bdd6503d5716f8c4082a238ee5f9393047efe..59e9738fd3a675c48549c9993c7fefd8e2090889 100644 (file)
--- a/res/res_pjsip_authenticator_digest.c
+++ b/res/res_pjsip_authenticator_digest.c
@@ -206,9 +206,12 @@ static int build_nonce(struct ast_str **nonce, const char *timestamp, const pjsi
        RAII_VAR(char *, eid, ao2_global_obj_ref(entity_id), ao2_cleanup);
        char hash[33];
 
+       /*
+        * Note you may be tempted to think why not include the port. The reason
+        * is that when using TCP the port can potentially differ from before.
+        */
        ast_str_append(&str, 0, "%s", timestamp);
        ast_str_append(&str, 0, ":%s", rdata->pkt_info.src_name);
-       ast_str_append(&str, 0, ":%d", rdata->pkt_info.src_port);
        ast_str_append(&str, 0, ":%s", eid);
        ast_str_append(&str, 0, ":%s", realm);
        ast_md5_hash(hash, ast_str_buffer(str));