]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf evsel: Reduce a variables scope
authorIan Rogers <irogers@google.com>
Wed, 18 Sep 2024 22:31:16 +0000 (00:31 +0200)
committerNamhyung Kim <namhyung@kernel.org>
Mon, 30 Sep 2024 20:48:27 +0000 (13:48 -0700)
In __evsel__config_callchain avoid computing arch until code path that
uses it.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Dominique Martinet <asmadeus@codewreck.org>
Cc: Ze Gao <zegao2021@gmail.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Weilin Wang <weilin.wang@intel.com>
Link: https://lore.kernel.org/r/20240918223116.127386-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/evsel.c

index edfb376f06119460e2052cf460591f2399585d11..da0bada62140d9b013bc66937746818942196750 100644 (file)
@@ -859,7 +859,6 @@ static void __evsel__config_callchain(struct evsel *evsel, struct record_opts *o
 {
        bool function = evsel__is_function_event(evsel);
        struct perf_event_attr *attr = &evsel->core.attr;
-       const char *arch = perf_env__arch(evsel__env(evsel));
 
        evsel__set_sample_bit(evsel, CALLCHAIN);
 
@@ -890,6 +889,8 @@ static void __evsel__config_callchain(struct evsel *evsel, struct record_opts *o
 
        if (param->record_mode == CALLCHAIN_DWARF) {
                if (!function) {
+                       const char *arch = perf_env__arch(evsel__env(evsel));
+
                        evsel__set_sample_bit(evsel, REGS_USER);
                        evsel__set_sample_bit(evsel, STACK_USER);
                        if (opts->sample_user_regs &&