]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/resctrl: Make prefetch_disable_bits belong to the arch code
authorJames Morse <james.morse@arm.com>
Tue, 11 Mar 2025 18:37:10 +0000 (18:37 +0000)
committerBorislav Petkov (AMD) <bp@alien8.de>
Wed, 12 Mar 2025 11:24:30 +0000 (12:24 +0100)
prefetch_disable_bits is set by rdtgroup_locksetup_enter() from a value
provided by the architecture, but is largely read by other architecture
helpers.

Make resctrl_arch_get_prefetch_disable_bits() set prefetch_disable_bits so
that it can be isolated to arch-code from where the other arch-code helpers
can use its cached value.

Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>
Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@google.com>
Tested-by: Amit Singh Tomar <amitsinght@marvell.com> # arm64
Tested-by: Shanker Donthineni <sdonthineni@nvidia.com> # arm64
Tested-by: Babu Moger <babu.moger@amd.com>
Link: https://lore.kernel.org/r/20250311183715.16445-26-james.morse@arm.com
arch/x86/kernel/cpu/resctrl/pseudo_lock.c

index 1f42c1190d26d8580e4e4fad7aa62760100007d1..90044a01d000392e76cd8a146e92d92065572f78 100644 (file)
@@ -84,6 +84,8 @@ static const struct class pseudo_lock_class = {
  */
 u64 resctrl_arch_get_prefetch_disable_bits(void)
 {
+       prefetch_disable_bits = 0;
+
        if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
            boot_cpu_data.x86 != 6)
                return 0;
@@ -99,7 +101,8 @@ u64 resctrl_arch_get_prefetch_disable_bits(void)
                 * 3    DCU IP Prefetcher Disable (R/W)
                 * 63:4 Reserved
                 */
-               return 0xF;
+               prefetch_disable_bits = 0xF;
+               break;
        case INTEL_ATOM_GOLDMONT:
        case INTEL_ATOM_GOLDMONT_PLUS:
                /*
@@ -110,10 +113,11 @@ u64 resctrl_arch_get_prefetch_disable_bits(void)
                 * 2     DCU Hardware Prefetcher Disable (R/W)
                 * 63:3  Reserved
                 */
-               return 0x5;
+               prefetch_disable_bits = 0x5;
+               break;
        }
 
-       return 0;
+       return prefetch_disable_bits;
 }
 
 /**
@@ -713,8 +717,7 @@ int rdtgroup_locksetup_enter(struct rdtgroup *rdtgrp)
         * Not knowing the bits to disable prefetching implies that this
         * platform does not support Cache Pseudo-Locking.
         */
-       prefetch_disable_bits = resctrl_arch_get_prefetch_disable_bits();
-       if (prefetch_disable_bits == 0) {
+       if (resctrl_arch_get_prefetch_disable_bits() == 0) {
                rdt_last_cmd_puts("Pseudo-locking not supported\n");
                return -EINVAL;
        }