]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainNetDefParseXML: avoid leak upon multiple "filterref"
authorJim Meyering <meyering@redhat.com>
Tue, 18 May 2010 08:19:30 +0000 (10:19 +0200)
committerJim Meyering <meyering@redhat.com>
Tue, 18 May 2010 17:23:27 +0000 (19:23 +0200)
* src/conf/domain_conf.c (virDomainNetDefParseXML): Don't leak
memory when parsing two or more "filterref" elements.

src/conf/domain_conf.c

index 3e45f7959fb7633236c9dbfa894842efb4b6dd01..20c9c51883e877f27b45cdec43c6d3ffec6fd56c 100644 (file)
@@ -1905,6 +1905,7 @@ virDomainNetDefParseXML(virCapsPtr caps,
                 model = virXMLPropString(cur, "type");
             } else if (xmlStrEqual (cur->name, BAD_CAST "filterref")) {
                 filter = virXMLPropString(cur, "filter");
+                VIR_FREE(filterparams);
                 filterparams = virNWFilterParseParamAttributes(cur);
             } else if ((flags & VIR_DOMAIN_XML_INTERNAL_STATUS) &&
                        xmlStrEqual(cur->name, BAD_CAST "state")) {