]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
coverity: #1425768
authorChristian Brauner <christian.brauner@ubuntu.com>
Thu, 14 Jun 2018 20:17:08 +0000 (22:17 +0200)
committerChristian Brauner <christian.brauner@ubuntu.com>
Mon, 10 Dec 2018 08:18:14 +0000 (09:18 +0100)
Untrusted array index read

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
src/lxc/state.c

index 45d08b15c615586aee2aa4c97f1cb3a57470051c..47e6712498299275655103cb8735f422101ef8b0 100644 (file)
@@ -109,7 +109,7 @@ static int fillwaitedstates(const char *strstates, lxc_state_t *states)
 extern int lxc_wait(const char *lxcname, const char *states, int timeout,
                    const char *lxcpath)
 {
-       int state;
+       int state = -1;
        lxc_state_t s[MAX_STATE] = {0};
 
        if (fillwaitedstates(states, s))
@@ -134,6 +134,11 @@ extern int lxc_wait(const char *lxcname, const char *states, int timeout,
                sleep(1);
        }
 
+       if (state < 0) {
+               ERROR("Failed to retrieve state from monitor");
+               return -1;
+       }
+
        TRACE("Retrieved state of container %s", lxc_state2str(state));
        if (!s[state])
                return -1;